Open
Conversation
Collaborator
|
Thanks for the pull request. I guess I will merge the db check. Just out of curiosity. What is your scenario that |
Author
|
There was an error, but the Sorry for the delayed response, I'm not getting notifications anymore :( |
Collaborator
|
Ok, no problem. Thanks for the clarification. I will merge the pr after my vacation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an if statement to check if db is defined before attempting to use it in the connect method. Also added an option for skipping errors on insert in included commits but removed them. Removed connection string config from error message, to rely just on MongoDB error object for debugging (relevant to my project).
So, basically, just added the db check to the connect method. Feel free to skip the other stuff, I was just prototyping some stuff for a project.