expose RtpParameters.Encoding's minBitrateBps to VideoEncoding#619
Open
andyli wants to merge 2 commits intolivekit:mainfrom
Open
expose RtpParameters.Encoding's minBitrateBps to VideoEncoding#619andyli wants to merge 2 commits intolivekit:mainfrom
andyli wants to merge 2 commits intolivekit:mainfrom
Conversation
🦋 Changeset detectedLatest commit: c1b5f64 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
andyli
force-pushed
the
VideoEncoding.minBitrate
branch
from
5e8b000 to
db894fa
Compare
davidliu
reviewed
Mar 17, 2025
livekit-android-sdk/src/main/java/io/livekit/android/room/track/LocalVideoTrackOptions.kt
Outdated
Show resolved
Hide resolved
Contributor
|
Can you rebase main? One of the github actions needed to be updated to get the workflows working again. |
andyli
force-pushed
the
VideoEncoding.minBitrate
branch
from
db894fa to
c1b5f64
Compare
Author
|
Rebased and minBitrate defaults to null now. |
Author
|
Any chance to merge this soon? :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR: Allow users to set a min bitrate. It is useful in situations where there is some minimal network bandwidth guarantee.
I observed that the video stream from my Android app, built with LiveKit Android, always starts with a lower bitrate (as low as ~100kbps), even if I've configured it to have a maximum bitrate of 8000kbps. After around 2 minutes, the bitrate goes up to 3000kbps and reaches almost 8000kbps after a while.
Setting the min bitrate to 6000kbps allowed me to get an initial bitrate of ~4000kbps from the beginning.