Skip to content

fixed ../../.pub-cache/hosted/pub.dev/livekit_client-2.6.2/lib/src/tr…#979

Closed
Adityakaldhone wants to merge 2 commits intolivekit:mainfrom
Adityakaldhone:ix--Fix-@internal-missing-meta-import
Closed

fixed ../../.pub-cache/hosted/pub.dev/livekit_client-2.6.2/lib/src/tr…#979
Adityakaldhone wants to merge 2 commits intolivekit:mainfrom
Adityakaldhone:ix--Fix-@internal-missing-meta-import

Conversation

@Adityakaldhone
Copy link

@Adityakaldhone Adityakaldhone commented Feb 5, 2026

…ack/local/video.dart:178:4: Error: Undefined name 'internal' this issue

Summary by CodeRabbit

  • Chores
    • Internal maintenance: minor code annotation and hygiene updates with no impact on functionality or user experience.

…ack/local/video.dart:178:4: Error: Undefined name 'internal' this issue
@coderabbitai
Copy link

coderabbitai bot commented Feb 5, 2026

📝 Walkthrough

Walkthrough

Added a package:meta/meta.dart import and updated the private LocalVideoTrack constructor annotation from @internal to @meta.internal in lib/src/track/local/video.dart. No other functional changes.

Changes

Cohort / File(s) Summary
Local video track
lib/src/track/local/video.dart
Added package:meta/meta.dart import and prefixed the existing @internal annotation with @meta.internal on the private LocalVideoTrack constructor. No behavior changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • hiroshihorie

Poem

🐰 A quiet hop, a tiny tweak,
I added meta for the sake of tweak,
One import and a name prefixed,
The track stays steady, nothing mixed. ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The title is truncated and unclear, appearing to be a file path rather than a meaningful description of the change. Replace the title with a clear, concise description such as 'Add meta import for @internal annotation on LocalVideoTrack' that accurately describes the actual change made.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7b9f0c1 and da01475.

📒 Files selected for processing (1)
  • lib/src/track/local/video.dart
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
  • GitHub Check: Build for Flutter macOS
  • GitHub Check: Build for Flutter Web
  • GitHub Check: Build for Flutter Windows
  • GitHub Check: Build for Flutter Web WASM
  • GitHub Check: Build for Flutter Linux
  • GitHub Check: Build for Flutter iOS
  • GitHub Check: Build for Flutter Android
🔇 Additional comments (2)
lib/src/track/local/video.dart (2)

19-19: LGTM - Import correctly adds the meta package.

The aliased import follows the existing pattern in this file. Alternatively, you could use import 'package:meta/meta.dart' show internal; to enable the simpler @internal annotation syntax, but the current approach is consistent with the file's style.


178-185: LGTM - Correctly fixes the undefined @internal annotation.

The @meta.internal annotation properly marks this constructor as package-internal, which is appropriate since it's only called by the static factory methods (createCameraTrack, createScreenShareTrack, createScreenShareTracksWithAudio) within this file.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@CLAassistant
Copy link

CLAassistant commented Feb 5, 2026

CLA assistant check
All committers have signed the CLA.

…ack/local/video.dart:178:4: Error: Undefined name 'internal' this issue
@Adityakaldhone
Copy link
Author

fix: add missing meta import for @internal annotation in local video track

Description
The Issue
During the integration of livekit_client 2.6.2, the compilation failed with the following error in lib/src/track/local/video.dart:

Error: Undefined name 'internal'. @internal

Detailed error occuring in flutter while running flutter app:
../../.pub-cache/hosted/pub.dev/livekit_client-2.6.2/lib/src/track/local/video.dart:178:4: Error:

Undefined name 'internal'.

[ ] [ ] @internal

[ ] [ ] ^^^^^^^^

This error occurs because the @internal annotation requires the meta package, which was not imported in this specific file, causing the compiler to treat it as an undefined name rather than a valid constant.

The Fix
I have added the missing import statement to lib/src/track/local/video.dart:
import 'package:meta/meta.dart';

Verification Results
Compilation: The project now builds successfully without kernel_snapshot failures.

Functionality: Verified that Room creation and joining are working as expected after the fix.

My Flutter Version :
Flutter 3.32.2 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 8defaa71a7 (8 months ago) • 2025-06-04 11:02:51 -0700
Engine • revision 1091508939 (8 months ago) • 2025-05-30 12:17:36 -0700
Tools • Dart 3.8.1 • DevTools 2.45.1

@hiroshihorie
Copy link
Member

Hi @Adityakaldhone, thanks so much for the PR! I’m going to close this one in favor of #981, which addresses import errors more broadly. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants