-
Notifications
You must be signed in to change notification settings - Fork 104
fix(deps): update dependency jose to v6 #426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
renovate
wants to merge
1
commit into
main
Choose a base branch
from
renovate/jose-6.x
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Package engines field claims Node.js >=18 but jose v6 drops Node.js 18 support and breaks CJS on Node <22
Updating jose to
^6.0.0without updating theenginesfield creates a compatibility mismatch. The package declares"node": ">=18"but jose v6 explicitly drops support for Node.js 18.x and earlier. More critically, jose v6 states: "CJS-style require is now only possible when require(esm) support is present in the Node.js runtime" (require(esm)was added in Node.js 22).Impact on CJS consumers
The package exports a CJS entry point at
packages/livekit-server-sdk/package.json:24("default": "./dist/index.cjs"). Sincejoseis a runtime dependency (not bundled), the CJS build will attempt torequire('jose')at runtime. On Node.js versions 18–21, this will fail because jose v6 ships only ESM and those runtimes do not supportrequire(esm). Users on Node.js 18 or 20 (both current LTS lines) who consume livekit-server-sdk viarequire()will get a runtime error.The
enginesfield at line 65 should be updated to reflect the actual minimum Node.js version required by the dependency graph (at minimum>=20, or>=22if CJS support is needed).Prompt for agents
Was this helpful? React with 👍 or 👎 to provide feedback.