Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #47 +/- ##
==========================================
+ Coverage 55.43% 55.83% +0.39%
==========================================
Files 18 19 +1
Lines 1407 1422 +15
==========================================
+ Hits 780 794 +14
- Misses 627 628 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Is this not showing up in Aqua because the ambiguity only is there if CUDA is loaded? |
|
Yes basically exactly that. |
|
lol "amgiguating" |
|
Annoying, more ambiguities to fix. |
e5d63ac to
6f44092
Compare
|
OK, I think this is ok to go (but we'll want to fix |
|
OK, created a more specific |
6f631e0 to
b6ed4ee
Compare
|
I think everything got resolved here? |
|
Now with a |
7d8a688 to
2d7ce3c
Compare
|
I'd really like to get this last scalar indexing thing squared away before merging this (it makes me antsy) so I'll keep plugging away. |
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
Co-authored-by: Lukas Devos <ldevos98@gmail.com>
|
OK gotta wait for the registry to update |
This seems to be needed for conversion of
BlockTensorMaps backed by GPU arrays toCuTensorMap-- otherwise an ambiguity error arises.