lkl: add LKL_HIJACK_NET_QDISC to configure qdisc policy#315
lkl: add LKL_HIJACK_NET_QDISC to configure qdisc policy#315liuyuan10 merged 1 commit intolkl:masterfrom
Conversation
tavip
left a comment
tavip
left a comment
There was a problem hiding this comment.
There is a small coding style issue, but the code looks good.
Documentation/lkl.txt
Outdated
| ``` | ||
| * LKL_HIJACK_NET_QDISC | ||
|
|
||
| Add a qdisc entry in the form of "ip|mac;ip|mac;...". |
tools/lkl/include/lkl.h
Outdated
| * @entries - strings of qdisc configurations in the form of | ||
| * "root|type;root|type;..." | ||
| */ | ||
| void lkl_qdisc_parse_add(int ifindex, char* entries); |
There was a problem hiding this comment.
I don't think this should be part of lkl.h.
There was a problem hiding this comment.
the same reason as #319 (comment)
I believe those are useful for others.
maybe other LKL_HIJACK_xxx configs (arp, nd, etc) can be moved in this sense.
Ah thanks, I found those issues. will fix them. I was wondering why circleci didn't report those though.. |
good catch - I will add a test. |
thehajime
force-pushed
the
feature-qdisc
branch
4 times, most recently
from
ed5837f to
024dc9d
Compare
Also enable SCH_FQ to be able to use it. Signed-off-by: Hajime Tazaki <thehajime@gmail.com>
thehajime
force-pushed
the
feature-qdisc
branch
from
024dc9d to
b376786
Compare
Off topic: I found I configured SKIP_CHECKPATCH in my circleci instance and this prevents me to check the style in advance. So everything is fine. |
3 participants
Also enable SCH_FQ to be able to use it.
Signed-off-by: Hajime Tazaki thehajime@gmail.com
This change is