Open
Conversation
Member
|
Since the addition makes bigger liblkl (and potentially slow down something), I don't think it's fine to merge to lkl.
I think if the patchset includes some utility functions (maybe generalized one of your hacky code) in tools/lkl/lib/net.c to configure iptable rules, it would be nicer to accept this patch. The following PR might be an example of those addition. |
Member
|
Agree with @thehajime , maybe we can have a different defconfig for this? See #440 |
|
Can one of the admins verify this patch? |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi guys,
I know this is a (very) early PR, but I wanted to start off the conversation. I'm looking to test firewall rulesets and the like and LKL seems to be a really good way to do that - except it doesn't have firewall support.
The change I've made compiles in all of the netfilter / iptables modules. This is sufficient to allow
iptablesto show and list any rules. I wrote a hacky bit of code to inject a rule as part of thehijacklib, and was able to see it withiptables -L. A simple set of tests withpingalso confirmed that the rules were working as expected.liblkl.sois about 6MB larger after this change.Of course, this set up is not going to be very useful without being able to load a proper rule set. My current plan is to compile
iptablesas a library and modifyhijackto load the provided ruleset as part of initialisation.I'm keen to contribute back to the project and I'm completely happy to change or implement this differently if that would be preferred.
As before, any guidance would be gratefully received :)
This change is