Add LC_ALL=C to cc-objdump-file-format.sh for awk to work properly#614
Merged
tavip merged 1 commit intolkl:masterfrom Aug 21, 2025
Merged
Add LC_ALL=C to cc-objdump-file-format.sh for awk to work properly#614tavip merged 1 commit intolkl:masterfrom
tavip merged 1 commit intolkl:masterfrom
Conversation
ddiss
approved these changes
Aug 20, 2025
ddiss
left a comment
There was a problem hiding this comment.
Looks fine, although I'm a little confused as to why other $OBJDUMP output parsers (e.g. arch/x86/tools/Makefile) don't need this. Which locale are you using?
Author
|
I'm using As far as I can see, |
23d8925 to
bd914ba
Compare
Author
|
ok, done! |
Member
|
Thanks @elkcl, could you also please fix the author name in the git commit to avoid checkpatch complaining? |
26ac604 to
a0b4877
Compare
Signed-off-by: Ilya Denisyev <dev@elkcl.ru>
a0b4877 to
49f9937
Compare
Author
|
Sure, should be good to go now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a non-English locale is used,
awkfails to properly extract the file format fromobjdumpoutput, leading to build errors such as this:The problem is fixed by making sure that
objdumpuses the C locale.