chore(build): updates 3rd-party build dependencies#80
Open
abacaphiliac wants to merge 1 commit intolloyd:masterfrom
abacaphiliac:dev-deps
Open
chore(build): updates 3rd-party build dependencies#80abacaphiliac wants to merge 1 commit intolloyd:masterfrom abacaphiliac:dev-deps
abacaphiliac wants to merge 1 commit intolloyd:masterfrom
abacaphiliac:dev-deps
Conversation
…ies in npm devDependencies. updates Makefile to reference new location of devDependencies in `node_modules`. ignores generated `package-lock.json` file and `node_modules` directory. extracts `.jshintrc` from deleted `jshint-check.js`. adds incredibly basic `CONTRIBUTING.md` to document installation of deps and running `make` to build/minify and execute tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hi @lloyd , this is an extension of #10
devDependenciesMakefileto reference new location ofdevDependenciesin the project'snode_modulesdirectorypackage-lock.jsonfile andnode_modulesdirectory.jshintrcfrom deletedjshint-check.jsCONTRIBUTING.mdto document installation of deps and runningmaketo build/minify and execute testsif you're on board with this kind of change, i'll follow up with proposals to do the same with jquery for browser tests, and get a travis CI build running on this thing. please let me know what you think!