Skip to content

[transform_ext] Useful Python-defined TransformOpInterface ops#68

Open
rolfmorel wants to merge 1 commit intomainfrom
users/rolfmorel/transform-ops
Open

[transform_ext] Useful Python-defined TransformOpInterface ops#68
rolfmorel wants to merge 1 commit intomainfrom
users/rolfmorel/transform-ops

Conversation

@rolfmorel
Copy link
Contributor

No description provided.

Copy link
Member

@adam-smnk adam-smnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great utility 👍
It'll be particularly helpful with support transform like IR traversal etc.
And a good staging ground toward testing new ideas before upstreaming.

from mlir.dialects.transform import DiagnosedSilenceableFailure


def register_and_load(**kwargs):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to do with PR itself but an random idea.
I wonder if this could be done automatically on module import.

Copy link
Member

@rengolin rengolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is pretty cool

__all__ = ["register_and_load", "transform_ext"]


def register_and_load(**kwargs):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just us from dialects import register_and_load?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants