Abstract Pipeline creation (including pipeline layouts and root signatures)#1070
Open
manon-traverse wants to merge 4 commits intollvm:mainfrom
Open
Abstract Pipeline creation (including pipeline layouts and root signatures)#1070manon-traverse wants to merge 4 commits intollvm:mainfrom
manon-traverse wants to merge 4 commits intollvm:mainfrom
Conversation
manon-traverse
commented
Apr 9, 2026
include/API/Enums.h
Outdated
Comment on lines
+27
to
+29
| enum class Format { | ||
| R8Sint, | ||
| R8g8Sint, |
Contributor
Author
There was a problem hiding this comment.
#1020 already adds a Format enum. We should use that one once that PR hits main. For this reason, I have marked this PR as a draft.
manon-traverse
commented
Apr 9, 2026
Comment on lines
+71
to
+74
| std::string Name; | ||
| Format Format; | ||
| uint32_t OffsetInBytes; | ||
| std::optional<uint32_t> InstanceStepRate; |
Contributor
Author
There was a problem hiding this comment.
This misses some parameters that are not used. Those will be added once we need them.
manon-traverse
force-pushed
the
render-backend-api-pipeline-state
branch
2 times, most recently
from
dcfe0e4 to
241f8e7
Compare
manon-traverse
force-pushed
the
render-backend-api-pipeline-state
branch
from
241f8e7 to
01ee86c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an API-agnostic way of creating compute and graphics pipelines. This includes the creation of pipeline layouts and root signatures. In Metal, there is no real equivalent due to the use of a top-level argument buffer, so the BindingsDesc variable is ignored.