Add a VK::toError function to simplify vulkan error handling.#1085
Open
manon-traverse wants to merge 1 commit intollvm:mainfrom
Open
Add a VK::toError function to simplify vulkan error handling.#1085manon-traverse wants to merge 1 commit intollvm:mainfrom
manon-traverse wants to merge 1 commit intollvm:mainfrom
Conversation
MarijnS95
reviewed
Apr 14, 2026
Comment on lines
+23
to
+24
| return llvm::createStringError("%s (VkResult = %d)", Msg.data(), | ||
| static_cast<int>(Result)); |
Contributor
There was a problem hiding this comment.
Not sure how much more effort it is to stringify the error codes (or at least a few common ones), and/or to translate a few common ones to std::error_code. HR::toError()` seems to do it but not sure if that yields any advantage or if anything "relies" on it...
Contributor
Author
There was a problem hiding this comment.
HR::toError just stores it as an integer under std::system_category. The only thing in practice is that the error number is logged. This kind of does the same thing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error handling on Vulkan was a bit manual and verbose, with random error codes being assigned. This PR simplifies this using a
VK::toErrorfunction (similar to theHR::toErrorfunction). This way, we preserve the original VkResult in the error message and don't have arbitrarily chosen error codes.