Append *default-special-bindings* set from elsewhere on thread creation#41
Append *default-special-bindings* set from elsewhere on thread creation#41leetwinski wants to merge 1 commit intolmj:masterfrom
Conversation
|
I am stmx author, and I confirm that removing some (or all) existing conses breaks any library (including mine) that add conses to it and rely on them to remain present. This patch looks correct to me: many libraries have reasons to add conses to Also, bordeaux-threads docs explicitly state so even in case a symbol already appears |
|
Does anyone have any problems with this pull request? |
|
As it can (hopefully) be deduced from my post above, I am definitely in favor of merging this pull request. |
|
I couldn't locate anyone able to approve and/or merge this. Also tried to reference it in sharplispers/lparallel. Also no luck. |
|
Last time I had luck make people aware in Reddit. |
Follow up on this discussion in
stmxrepository.We found out that
*default-special-bindings*special variable gets overwritten by kernel bindings inwith-threadmacro on thread creation.The patch solves this, appending the possibly existing values to kernel bindings. Fixes the interoperability issue with
stmxand possibly other libraries, relying on those thread bindings.