Update Lightning to 11.0.0 and TypeScript to ^5.9.3 Issue726

[Matobi98]

Summary

Updated the Lightning dependency to 11.0.0. This required upgrading TypeScript to ^5.9.3 (minimum required ≥ 5.4), so TypeScript was bumped to ^5.9.3.

Changes

• Bumped lightning to 11.0.0 in package.json.
• Upgraded typescript to ^5.9.3.
• Updated lockfile (package-lock.json / yarn.lock) accordingly.

Why

• Upgraded Lightning to v11 to receive security fixes, bug fixes, and feature improvements.
• TypeScript >= 5.4 is required for compatibility; using ^5.9.3 keeps the project on a recent stable release.

Summary by CodeRabbit

• Chores
  • Updated Lightning to version 11.0.0 for improved runtime capabilities.
  • Updated TypeScript to version 5.9.3 for enhanced language features and tooling.
  • Updated ESLint TypeScript tooling for linting improvements and minor formatting cleanup (removed trailing newline).

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Updated dependency versions in package.json: lightning bumped from 10.25.0 to ^11.0.0, typescript bumped from 5.1.6 to ^5.9.3; ESLint TypeScript packages updated. End-of-file newline removed. No changes to exported or public entity signatures.

Changes

Cohort / File(s)	Summary
Runtime & Tooling Dependencies package.json	Bumped lightning 10.25.0 → ^11.0.0 and typescript 5.1.6 → ^5.9.3 in package.json.
ESLint TypeScript Packages package.json	Updated @typescript-eslint/eslint-plugin and @typescript-eslint/parser 8.11.0 → 8.21.0 (devDependencies).
Whitespace package.json	Removed trailing end-of-file newline (no newline at end of file).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related issues

• Update Lightning dependency to version 11 #726: Both PRs upgrade the lightning package dependency from 10.25.0 to 11.0.0.

Poem

🐰 I hopped through package.json bright,

bumped lightning up to shine at night,
TypeScript donned a newer hue,
linters tuned their rules anew,
tiny whitespace — gone from sight.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main changes: updating Lightning to 11.0.0 and TypeScript to ^5.9.3, with a reference to the related issue.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@package.json`:
- Line 67: Update the `@typescript-eslint` packages to a newer 8.x release that
supports TypeScript 5.9.3: change the versions for `@typescript-eslint/parser` and
`@typescript-eslint/eslint-plugin` in package.json devDependencies to a current
8.x version that explicitly supports TS >=4.8.4 <6.0.0, then reinstall
(npm/yarn) to update lockfile; verify eslint still runs and lints files
referencing TypeScript by running your lint script or eslint directly.

[knocte]

Lightning v11 includes fixes and improvements needed by the project.

Can you specify which fixes and improvements are the ones you're after?

[Matobi98]

It was a mistake; I've updated the description to clarify the reason:

• Upgraded Lightning to v11 to receive security fixes, bug fixes, and feature improvement

[mostronatorcoder]

Review Summary

✅ Checks Passed

1. CI Status: All workflows pass (Lint, NodeJS CI, CodeQL)
2. Breaking Change Compatibility: lightning v11.0.0 only breaks Node.js 18 support (requires ≥20). The project already uses Node.js 20 in Dockerfile and has engines: {"node": ">=18.0.0"}, so this is compatible.
3. TypeScript Upgrade: 5.1.6 → 5.9.3 is a safe major bump with no known breaking changes for this codebase.
4. ESLint Plugins: @typescript-eslint/* 8.11.0 → 8.21.0 is a minor version bump.
5. Lockfile: package-lock.json correctly regenerated.

⚠️ Issues Found

1. Missing newline at EOF in package.json

   • The diff shows } without trailing newline:

   -}
   +}
   \ No newline at end of file

   • This violates POSIX standards and can cause issues with some tools.
   • Fix required: Add a newline at the end of package.json.

2. Version specifier inconsistency

   • lightning changed from exact (10.25.0) to caret (^11.0.0)
   • Other deps use exact versions (e.g., mongoose: 6.13.6, invoices: 2.0.6)
   • Recommendation: Use exact version 11.0.0 for consistency with existing patterns, OR document the reason for allowing minor updates.

3. engines.node should be updated

   • Current: >=18.0.0
   • With lightning v11.0.0 requiring Node.js ≥20, the engines field should be updated to >=20.0.0 to prevent installation on unsupported Node versions.
   • Fix recommended: Update engines.node to >=20.0.0.

📋 Checklist

• PR linked to issue #726
• CI passes
• No breaking runtime changes (Node 20 already in use)
• EOF newline in package.json
• Consider exact version for lightning
• Update engines.node to >=20.0.0

Verdict

Request Changes — The missing EOF newline is a clear issue. The engines.node update is strongly recommended to prevent future issues when someone tries to run on Node 18.

[knocte]

Fix recommended: Update engines.node to >=20.0.0.

But Ubuntu LTS (24.04) still has 18.x.

I recommend waiting until 26.04 is out the door to make this change (in April this year).