Conversation
bentsku
left a comment
There was a problem hiding this comment.
Thanks for adding this sample! 🚀 going to make it easier for our users to try it out.
I have a few comments, one regarding the default values for the Kinesis target, as we might want to use default values to fit more our users use-case, and maybe make it parametrizable?
And another regarding the Postgres external database that it seems we do not make use of.
Thanks!
bentsku
left a comment
There was a problem hiding this comment.
Nice, thanks for addressing the comments!
I still have 2 comments regarding the non-default, maybe we could explain a bit more what that means?
And there's still an env var left from the external Postgres server.
Once this is addressed, let's get this in for the release! 🚀
|
Thank you Sannya, great sample! |
bentsku
left a comment
There was a problem hiding this comment.
LGTM! Thanks for addressing the comments! 🚀
Setup the sample application for dms postgres as a source and kinesis target.