Browser authentication flow#9
Merged
carole-lavillonniere merged 1 commit intomainfrom Feb 3, 2026
Merged
Conversation
| log.Println("Authentication failed.") | ||
| return "", err | ||
| } | ||
| log.Println("Login successful.") |
Collaborator
Author
There was a problem hiding this comment.
Print directly for now but we will need to agree on a communication mechanism between business logic and TUI (callback functions/bubbletea messages pattern/channels etc)
carole-lavillonniere
force-pushed
the
drg-359-inline-token-authentication-with-environment-variable-for-ci
branch
from
6025783 to
0df30e7
Compare
Base automatically changed from
drg-359-inline-token-authentication-with-environment-variable-for-ci
to
main
February 3, 2026 13:44
carole-lavillonniere
force-pushed
the
drg-358-implement-browser-based-auth-flow
branch
from
a63e5e0 to
35fa4ec
Compare
carole-lavillonniere
deleted the
drg-358-implement-browser-based-auth-flow
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Dependencies
github.com/pkg/browserfor cross-platform browser openingIntegration test
TestStartCommandTriggersLoginWithoutToken: simulates browser callback to verify that the login flow works (LOCALSTACK_WEB_APP_URLenv var allows overriding webapp URL for testing)TODO
/redirect?name=CLIin webapp and execute CLI callback