feat(run-ginkgo): add composite action for Ginkgo test execution#97
Open
sydorovdmytro wants to merge 1 commit intomainfrom
Open
feat(run-ginkgo): add composite action for Ginkgo test execution#97sydorovdmytro wants to merge 1 commit intomainfrom
sydorovdmytro wants to merge 1 commit intomainfrom
Conversation
Centralizes the duplicated run-ginkgo-e2e logic from vcluster, loft-enterprise (local composite actions), and vcluster-pro (inline steps) into a single reusable composite action. The action is container-runtime agnostic — callers handle their own cluster and image setup (vind, Kind, etc.). Core responsibilities: install Ginkgo, execute tests with directory or label-based filtering, and generate a JSON failure summary. Structure follows repo conventions: - action.yml: thin YAML glue only - src/execute-tests.sh: builds ginkgo args, handles strategy, runs tests - src/generate-summary.sh: parses JSON report into markdown summary - test/: 32 bats tests covering both scripts - CI workflow + Makefile target Key inputs: test-image, test-image-flag, ginkgo-label/test-dir, additional-args, additional-ginkgo-flags, append-pr-label.
e080833 to
673bd65
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run-ginkgocomposite action that centralizes the duplicated Ginkgotest execution logic from all three production repos
setup (vind, Kind, etc.)
logic in
src/scripts, bats tests intest/Action structure
Replaces
.github/actions/run-ginkgo-e2e/(local composite action).github/actions/run-ginkgo-e2e/(local composite action)e2e-next.yaml+e2e-next-nightly.yamlKey inputs
test-imagetest-image-flag--vcluster-imageginkgo-label/test-dirappend-pr-labeltrue|| prto label filteradditional-ginkgo-flags-v,--skip-package=linters)additional-argsTest plan
make lint)make test-run-ginkgo)