Skip to content

refactor (dep): Introduce more submodules and update fl_lib submodule#1060

Merged
GT-610 merged 2 commits intolollipopkit:mainfrom
GT-610:main
Feb 28, 2026
Merged

refactor (dep): Introduce more submodules and update fl_lib submodule#1060
GT-610 merged 2 commits intolollipopkit:mainfrom
GT-610:main

Conversation

@GT-610
Copy link
Collaborator

@GT-610 GT-610 commented Feb 28, 2026

Summary by CodeRabbit

  • Chores
    • Moved three packages from external repositories into the local workspace for easier local development
    • Switched project package references to use local workspace packages
    • Removed an obsolete dependency override to simplify configuration
    • Updated submodule registrations to match the new local package layout

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 28, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 40f26f3 and d833456.

📒 Files selected for processing (1)
  • .gitmodules

📝 Walkthrough

Walkthrough

Adds three Git submodules (circle_chart, plain_notification_token, watch_connectivity) and corresponding subproject commit references under packages/. Updates pubspec.yaml to replace those three Git dependencies with local path references to packages/* and removes a commented dependency_override entry. Updates the packages/fl_lib submodule pointer to a new commit hash. No source code or public API changes inside the added submodules are included in this PR.

Possibly related PRs

Suggested reviewers

  • lollipopkit
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main changes: introducing three new submodules (circle_chart, plain_notification_token, watch_connectivity) and updating the fl_lib submodule pointer.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai bot requested a review from lollipopkit February 28, 2026 12:05
Copy link

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.gitmodules (1)

21-29: Add explicit branch field for consistency.

All existing submodules in this file explicitly specify a branch field, but the three new submodules (circle_chart, plain_notification_token, and watch_connectivity) omit it. While Git will default to the repository's default branch, explicitly specifying the branch improves clarity and consistency with the established pattern.

📋 Proposed fix to add branch specification
 [submodule "circle_chart"]
 	path = packages/circle_chart
 	url = https://github.com/lollipopkit/circle_chart
+	branch = main
 [submodule "plain_notification_token"]
 	path = packages/plain_notification_token
 	url = https://github.com/lollipopkit/plain_notification_token
+	branch = main
 [submodule "watch_connectivity"]
 	path = packages/watch_connectivity
 	url = https://github.com/lollipopkit/watch_connectivity
+	branch = main
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.gitmodules around lines 21 - 29, The three new submodule entries (submodule
"circle_chart", "plain_notification_token", and "watch_connectivity") are
missing an explicit branch field; update each submodule block to include a
branch = <branch-name> line matching the repo's intended branch (e.g., main or
master) to match the existing pattern used by other submodules in .gitmodules so
all entries consistently declare their branch.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In @.gitmodules:
- Around line 21-29: The three new submodule entries (submodule "circle_chart",
"plain_notification_token", and "watch_connectivity") are missing an explicit
branch field; update each submodule block to include a branch = <branch-name>
line matching the repo's intended branch (e.g., main or master) to match the
existing pattern used by other submodules in .gitmodules so all entries
consistently declare their branch.

ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bc69686 and 40f26f3.

⛔ Files ignored due to path filters (1)
  • pubspec.lock is excluded by !**/*.lock
📒 Files selected for processing (6)
  • .gitmodules
  • packages/circle_chart
  • packages/fl_lib
  • packages/plain_notification_token
  • packages/watch_connectivity
  • pubspec.yaml

coderabbitai[bot]
coderabbitai bot previously approved these changes Feb 28, 2026
@GT-610 GT-610 merged commit ac46073 into lollipopkit:main Feb 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant