Skip to content

Add client scope mapper crud#42

Merged
looorent merged 8 commits intolooorent:mainfrom
AaronCDee:add-scope-mapper-crud
Mar 26, 2026
Merged

Add client scope mapper crud#42
looorent merged 8 commits intolooorent:mainfrom
AaronCDee:add-scope-mapper-crud

Conversation

@AaronCDee
Copy link
Copy Markdown
Contributor

This merge request adds CRUD support for client-scope protocol mappers.

It adds a new client_authz_scope_protocol_mapper_client to add the mappers via the API.

Please let me know what you think and if there's any improvements you would like me to make. :)

@AaronCDee
Copy link
Copy Markdown
Contributor Author

If this is approved, would you like me to add documentation as well on how to use this?

Copy link
Copy Markdown
Owner

@looorent looorent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice PR, @AaronCDee , thank you!
There is mostly a naming issue between the classes/accessors and the actual concept used in Keycloak.
Yes, you can also add a little bit of documentation in the README.md about this new feature.

@AaronCDee
Copy link
Copy Markdown
Contributor Author

@looorent thanks so much for the quick response. I've adjusted the PR as per the feedback and added documentation. Please take a look and let me know what you think.

@AaronCDee
Copy link
Copy Markdown
Contributor Author

@looorent , I'm going to add the client scopes to this one as well.

@AaronCDee
Copy link
Copy Markdown
Contributor Author

@looorent , I'm going to add the client scopes to this one as well.

I will need that as well as part of my integration. I mistakenly thought authz_client_scopes were what I needed... 😅 Standby for more updates :)

@looorent looorent merged commit 6e4f4cc into looorent:main Mar 26, 2026
1 check passed
@looorent
Copy link
Copy Markdown
Owner

@AaronCDee Bad timing on my part! I just merged this while your comment was coming through. :/

Could you follow up with a new PR for those extra features?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants