Conversation
|
If this is approved, would you like me to add documentation as well on how to use this? |
looorent
left a comment
There was a problem hiding this comment.
This is a nice PR, @AaronCDee , thank you!
There is mostly a naming issue between the classes/accessors and the actual concept used in Keycloak.
Yes, you can also add a little bit of documentation in the README.md about this new feature.
lib/keycloak-admin/client/client_authz_scope_protocol_mapper_client.rb
Outdated
Show resolved
Hide resolved
|
@looorent thanks so much for the quick response. I've adjusted the PR as per the feedback and added documentation. Please take a look and let me know what you think. |
|
@looorent , I'm going to add the client scopes to this one as well. |
I will need that as well as part of my integration. I mistakenly thought |
|
@AaronCDee Bad timing on my part! I just merged this while your comment was coming through. :/ Could you follow up with a new PR for those extra features? |
This merge request adds CRUD support for client-scope protocol mappers.
It adds a new
client_authz_scope_protocol_mapper_clientto add the mappers via the API.Please let me know what you think and if there's any improvements you would like me to make. :)