Conversation
|
@looorent No worries about the other one. I just realized today that authz scopes were not the same as client scopes, so that's on me :). I've also changed the client for protocol mappers to use |
| rep.description = hash["description"] | ||
| rep.protocol = hash["protocol"] | ||
| rep.attributes = hash["attributes"] | ||
| rep.protocolMappers = (hash["protocolMappers"] || []).map { |m| ProtocolMapperRepresentation.from_hash(m) } |
There was a problem hiding this comment.
Why did you use camel case on the Representation?
They are supposed to be snake case
There was a problem hiding this comment.
Ahh, I thought so... I saw that in the protocol_mapper_representation that it uses camel case for protocolMapper, so I wanted to remain consistent with the naming. I'll adjust to use snake case, thanks. :)
There was a problem hiding this comment.
Would you like me to fix the protocol_mapper_representation while I'm at it? :)
There was a problem hiding this comment.
This would create a breaking change. This is not ideal but I think this is better to keep the (wrong) old protocolMappers as it is, and change the new one.
There was a problem hiding this comment.
Okay, cool, thanks. I've added the adjustment. This one should be ready to go. :)
|
Thanks for your contributions, @AaronCDee ! |
2 participants
This PR adds client scope CRUD to manage scopes for a given realm.
Please take a look and let me know what you think.