Draft
Conversation
denny241
force-pushed
the
feature-configure-directory-listing
branch
from
ba84d9e to
b5d9ea4
Compare
denny241
force-pushed
the
feature-configure-directory-listing
branch
from
9b5738e to
f3e6215
Compare
Morishiri
requested changes
Sep 9, 2022
| disableOldCiphers: false, | ||
| tunnelId: uuidv4(), | ||
| }, | ||
| deactivatedirectorylisting: false, |
Contributor
There was a problem hiding this comment.
Suggested change
| deactivatedirectorylisting: false, | |
| disableDirectoryListing: false, |
as in other places?
| disableOldCiphers: false, | ||
| tunnelId: uuidv4(), | ||
| }, | ||
| deactivatedirectorylisting: disableDirectoryListing |
Contributor
There was a problem hiding this comment.
Suggested change
| deactivatedirectorylisting: disableDirectoryListing | |
| disableDirectoryListing, |
as in other places?
| export default interface ExposeDirectoryMessage { | ||
| local: LocalDirectorySpecs; | ||
| remote: RemoteEndpointSpecs; | ||
| deactivatedirectorylisting: boolean; |
Contributor
There was a problem hiding this comment.
Suggested change
| deactivatedirectorylisting: boolean; | |
| disableDirectoryListing: boolean; |
| type DisplayConfig struct { | ||
| Verbose bool `json:"verbose"` | ||
| QR bool `json:"qr"` | ||
| DisableDirectoryListing bool `json:"disabledirectorylisting"` |
Contributor
There was a problem hiding this comment.
please use camelCase syntax
Suggested change
| DisableDirectoryListing bool `json:"disabledirectorylisting"` | |
| DisableDirectoryListing bool `json:"disableDirectoryListing"` |
| import React from "react"; | ||
|
|
||
| interface DirectorySettingsProps { | ||
| usingValue: boolean; |
Contributor
There was a problem hiding this comment.
why using? I would name it value and changeCallback
| communication.Warn(err.Error()) | ||
| } | ||
|
|
||
| config.Config.Display.DisableDirectoryListing = exposeDirectoryConfig.DisableDirectoryListing |
Contributor
There was a problem hiding this comment.
Would not use Display for that, they are not really for it. It's rather remoteEndpointSpecs the same way as here: https://github.com/loophole/cli/blob/master/cmd/http.go#L72
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial commit shows 404 when --disable-directory-listing flag is used and requested path is a directory, will look into the feasibility of showing a custom page instead.