fix: move revision info retrieval to the base FlowCfg#139
Merged
AlexJones0 merged 1 commit intolowRISC:masterfrom Apr 2, 2026
Merged
fix: move revision info retrieval to the base FlowCfg#139AlexJones0 merged 1 commit intolowRISC:masterfrom
FlowCfg#139AlexJones0 merged 1 commit intolowRISC:masterfrom
Conversation
In d6d53f6, the logic to record the commit hash (and shortened version) was added to the sim flow, but in reality since it is used in the deploy it needs to be on every flow. Move the computation of this information to the base `FlowCfg` object, after all expansion has taken place to fill in the `proj_root`. This should now work for the other flows (e.g. formal). Signed-off-by: Alex Jones <alex.jones@lowrisc.org>
This was referenced Apr 1, 2026
hcallahan-lowrisc
approved these changes
Apr 2, 2026
Contributor
hcallahan-lowrisc
left a comment
hcallahan-lowrisc
left a comment
There was a problem hiding this comment.
Seems pretty clear cut to me. Thanks for fixing the immediate issue @AlexJones0
This was referenced Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In d6d53f6 (as part of #109), the logic to record the commit hash (and shortened version) was added to the sim flow, but in reality since it is used in the deploy it needs to be on every flow.
Move the computation of this information to the base
FlowCfgobject, after all expansion has taken place to fill in theproj_root. This should now work for the other flows (e.g. formal).Closes #119.
Closes #133.