revert: "Correct the type for RunMode.build_mode"#166
Merged
AlexJones0 merged 1 commit intolowRISC:masterfrom Apr 4, 2026
Merged
revert: "Correct the type for RunMode.build_mode"#166AlexJones0 merged 1 commit intolowRISC:masterfrom
AlexJones0 merged 1 commit intolowRISC:masterfrom
Conversation
This reverts commit 7bc25f6. I think I intended to fix some typing problem, but the code in the "fix" was definitely wrong (causing build failures when the base class constructor doesn't set up build_mode in the way I expected). Undo the breakage (sorry). Signed-off-by: Rupert Swarbrick <rswarbrick@lowrisc.org>
AlexJones0
approved these changes
Apr 4, 2026
Contributor
AlexJones0
left a comment
AlexJones0
left a comment
There was a problem hiding this comment.
I'm glad I added the disclaimer on my original review 😅
What causes the breakage? Are some flows relying on constructing deploys with empty / partial build modes?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 7bc25f6. I think I intended to fix some typing problem, but the code in the "fix" was definitely wrong (causing build failures when the base class constructor doesn't set up build_mode in the way I expected).
Undo the breakage (sorry).