DM-37951: Allow PTC analysis to split each amp into subregions#251
Open
craiglagegit wants to merge 3 commits intomainfrom
Open
DM-37951: Allow PTC analysis to split each amp into subregions#251craiglagegit wants to merge 3 commits intomainfrom
craiglagegit wants to merge 3 commits intomainfrom
Conversation
plazas
changed the title
czwa
reviewed
Feb 13, 2023
| if len(self.covariances[ampName]) == 0: | ||
| self.covariances[ampName] = np.array(covArray) | ||
| else: | ||
| self.covariances[ampName] = np.concatenate((self.covariances[ampName],np.array(covArray))) |
Contributor
There was a problem hiding this comment.
I'm concerned about dimensionality here. Doesn't this take the NxN covariances and stack them to create an `(m_subregion*N)xN array?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is working, but it needs review and I'm sure it will need changes. I summarized the results in the Jira ticket