DM-53212: Add TrivialQuantumGraphBuilder#554
Open
mfisherlevine wants to merge 18 commits intomainfrom
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #554 +/- ##
==========================================
+ Coverage 88.64% 88.72% +0.08%
==========================================
Files 155 159 +4
Lines 21824 22054 +230
Branches 2602 2623 +21
==========================================
+ Hits 19345 19568 +223
Misses 1844 1844
- Partials 635 642 +7 ☔ View full report in Codecov by Sentry. |
TallJimbo
force-pushed
the
tickets/DM-53212
branch
3 times, most recently
from
602cabe to
aecd123
Compare
TallJimbo
approved these changes
Mar 18, 2026
mfisherlevine
force-pushed
the
tickets/DM-53212
branch
from
aecd123 to
6251edb
Compare
ktlim
reviewed
Mar 20, 2026
| ``butler`` is `None`. If one is supplied the other must not be. | ||
| limited_butler_factory : `~collections.abc.Callable`, optional | ||
| A method that creates a `~lsst.daf.butler.LimitedButler` instance for a | ||
| given Quantum. This parameter must be defined if ``butler`` is `None`. |
Contributor
There was a problem hiding this comment.
Should ideally update this docstring too.
Contributor
Author
There was a problem hiding this comment.
Agreed, and I updated the other one to mention that it's ignored if a butler is supplied too (as per this one's docstring).
mfisherlevine
force-pushed
the
tickets/DM-53212
branch
3 times, most recently
from
fb19d13 to
0b97eec
Compare
A glaring omission here is a test that blocks and then succeeds, which would require some combination of deeper mocking or threads.
mfisherlevine
force-pushed
the
tickets/DM-53212
branch
from
0b97eec to
ddc0fe9
Compare
mfisherlevine
force-pushed
the
tickets/DM-53212
branch
from
ddc0fe9 to
2a517d7
Compare
TallJimbo
force-pushed
the
tickets/DM-53212
branch
from
84a66a2 to
0496224
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
package-docs builddoc/changes