Tickets/sp 2868

[christinawilliams]

This ticket rewrote notebook 103.4 to focus only on cutout exposures (meaning ExposureF format; and also MaskedImageF format). This ticket also created new notebook 103.9 that demonstrates bulk cutouts (default format is a slimmed down ImageF format).

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[MelissaGraham]

It's 103.9 I think -- maybe better to say by name like "see also the 103-series tutorial on image stamps, which demonstrates how to generate bulk cutouts..."

Reply via ReviewNB

[christinawilliams]

Thanks! Updated!

[MelissaGraham]

Another ref to 103.5 to be changed

Reply via ReviewNB

[christinawilliams]

Updated!

[MelissaGraham]

In addition to the two embedded comments, here are some more small tweaks. I'm going to click "approve" to unblock your merge. Note you'll have to update with a rebase (do not just click update, use the drop-down).

103.4

Add the definitions and differences between cutout-sync, cutout-sync-exposure, and cutout-sync-mask (or is it cutout-sync-maskedimage) to the introduction. Right now this is down in S.3. Be clear in the introduction which service should be used for which use cases, and which services are demonstrated in this tutorial vs. elsewhere.

Then, can probably shorted the narrative text in S.3.

Section 4 says "Demonstrated above is the default cutout-sync which returns just the image extension" but that's not the case anymore.

Can you clarify what is missing from what is returned by cutout-sync-maskedimage? It has all three planes, flux, mask, variance, just like the results of cutout-sync-exposure.

103.9

Introduction -- For context, repeat the description of the cutout services and why cutout-sync is the default and the use case it's best suited for.

Some subsection headers are missing the period after the number.

Re. "shared /scratch directory" I think don't use /scratch because that's not actually the path. Can just say the "shared scratch directory" or "$SCRATCH_DIR" or "the shared scratch directory, /deleted-sundays/.

Add docstrings for all functions, and it looks like the indentation is off for the make_gif docstring.

Hotlink Papadogiannakis et al. 2018.

Remove trailing blank lines from code cells.

Section header for S.2.1. should probably be "Identify overlapping imagse" or something, because the cutout is not actually being created... actually the section header for S.2. is "Define Target" is not accurate for all of S.2. either... maybe reorganize like this:

S.2. Create single-epoch triplet stamps
S.2.1. Define target
S.2.2. Query SIA for images
S.2.3. Retrieve stamps
S.2.4. Rotate and display triplet

Then it makes sense that S.3. is bulk image stamps.

Try to keep consistent terminology, calling these cutouts "stamps" as in the title, to distinguish them from the cutout exposures in the other tutorial.

[christinawilliams]

In addition to the two embedded comments, here are some more small tweaks. I'm going to click "approve" to unblock your merge. Note you'll have to update with a rebase (do not just click update, use the drop-down).

103.4

Add the definitions and differences between cutout-sync, cutout-sync-exposure, and cutout-sync-mask (or is it cutout-sync-maskedimage) to the introduction. Right now this is down in S.3. Be clear in the introduction which service should be used for which use cases, and which services are demonstrated in this tutorial vs. elsewhere.

Done

Then, can probably shorted the narrative text in S.3.

Done

Section 4 says "Demonstrated above is the default cutout-sync which returns just the image extension" but that's not the case anymore.

Done

Can you clarify what is missing from what is returned by cutout-sync-maskedimage? It has all three planes, flux, mask, variance, just like the results of cutout-sync-exposure.

Still working on this as of 3/27 (now done 3/30)

[christinawilliams]

And now 103.9 comments have been implemented. Good to go!