Skip to content

SP-1030: NB 100 focal plane geometry#135

Merged
plazas merged 2 commits intomainfrom
tickets/SP-1030
Apr 3, 2026
Merged

SP-1030: NB 100 focal plane geometry#135
plazas merged 2 commits intomainfrom
tickets/SP-1030

Conversation

@plazas
Copy link
Copy Markdown
Contributor

@plazas plazas commented Apr 2, 2026

No description provided.

@plazas plazas requested a review from MelissaGraham April 2, 2026 19:51
@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Copy Markdown
Contributor

@MelissaGraham MelissaGraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Header isn't right -- use the code and logo from the current template in RTN-045 repo (_static).

Shorten learning objective to one sentence.

Can remove "matplotlib" from packages line, this can be only the core packages being taught... then again the whole purpose of this tutorial is plotting so maybe leave it after all...

Credit line, we don't track every individual's name in the credit line anymore, just use developed by CST. I have the Jira record to track contributions for performance reviews.

Not that it's a wellspring of info but, could link to https://pipelines.lsst.io/modules/lsst.geom/index.html as documentation for lsst.geom. And maybe similar for lsst.afw?

Section 1.2 it says "and define font sizes for the focal plane figure" but only colormap is defined.

I said it before but: I like the exercises for the learner, very achievable and useful to work through.

Approving PR so you can merge after the above little fixes.

@plazas plazas merged commit 604ca87 into main Apr 3, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants