cpuexporter: fix sum_stats mutation, nil dereference and timestamp unit#469
Closed
cpuexporter: fix sum_stats mutation, nil dereference and timestamp unit#469
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
endersonmaia
reviewed
Mar 9, 2026
| session:send(cpu_metrics()) | ||
| end | ||
|
|
||
| -- Initial sample |
Contributor
There was a problem hiding this comment.
I had this so that the first call to the metrics socket already returns the percentage, since I need at least two samples to calculate the percentage.
endersonmaia
reviewed
Mar 9, 2026
| local metrics = "" | ||
| local ts_ms = linux.time() // 1000 -- Convert to milliseconds (FIXME: note sure if this conversion is necessary) | ||
| local usage_data = cpu_usage() -- Call once and store the result | ||
| local ts_ms = linux.time() // 1000000 |
Contributor
There was a problem hiding this comment.
I think the precision was right but the comment was wrong.
Contributor
There was a problem hiding this comment.
actually the fix is correct, prometheus expects millisecods.
endersonmaia
approved these changes
Mar 9, 2026
Contributor
endersonmaia
left a comment
endersonmaia
left a comment
There was a problem hiding this comment.
Made two inline comments, but nothing blocking.
Contributor
Author
will work on them.. thanks! btw, can you summarize anything is pending here? I will try to fix it with claude ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.