Open
Conversation
klevisndoka
approved these changes
May 26, 2020
Owner
|
Hi @belidzs and @klevisndoka I am going to find time in the next week to review all these PRs and get a new release going. Thanks heaps for your work (and sorry for the delay on my end) |
Owner
|
This is very similar to #204 . I suggested maybe a renderer is the best option (though we might have to change some core core) |
Contributor
Author
|
@lukencode not really, these variables primarily serve as metadata, so using them in rendering is only a secondary thing. For instance if a developer sends a notification about a new invoice generated in their application they can pass the invoice ID so when the message is delivered (and mailgun calls your configured web service as a result) it also includes these variables as easily processable variables. |
|
Too bad this has bled to death |
a29f45a to
64cf341
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #201