This repository was archived by the owner on Jan 25, 2023. It is now read-only.
fix compiler warning with explicit cast#9
Open
ethansinjin wants to merge 3 commits intolukescott:masterfrom
Open
fix compiler warning with explicit cast#9ethansinjin wants to merge 3 commits intolukescott:masterfrom
ethansinjin wants to merge 3 commits intolukescott:masterfrom
Conversation
<UIScrollViewDelegate>delegate is not modified and inherits from superclass <TimelineViewDelegate>timelineViewDelegate
Owner
|
Awesome, thank you! I do prefer to keep the delegate the same. If you inherit from UIScrollView delegate as issue #7 suggests, it should fix the problem mentioned in that issue. It also may be a good idea to keep changes to feature branches. That way you can send specific things as pull requests, and you can make any custom changes to your master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.