breaking: Farewell to SampleHandlerFD#840
Merged
KSkwarczynski merged 10 commits intodevelopfrom Mar 25, 2026
Merged
Conversation
KSkwarczynski
requested review from
dbarrow257,
ewanwm and
henry-wallace-phys
as code owners
github-actions
Bot
added
MCMC
|
Hi @KSkwarczynski, thank you for contributing to MaCh3! Please wait for MaCh3 developers to review your PR. If no one answers within a week, please message people from this list: https://github.com/orgs/mach3-software/teams/mach3admin . While waiting, please enjoy this  Use this action on your projects. Use jokes on issues instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request description
Change SampleHandlerFD into SampleHandlerBase
While SampleHanlderBase become SampleHandlerInterface
In addition
SMonolith->UnbinnedSplineHandler
Most Get1DVarHist are using smart pointers now so we don't have to manually delete
Merge first mach3-software/MaCh3Tutorial#235
Changes or fixes
Examples