Skip to content

breaking: Ability to pass multiple MC files per channel and const correctness#842

Merged
KSkwarczynski merged 5 commits intodevelopfrom
kskwarczynski/breaking/multipleFiles
Mar 30, 2026
Merged

breaking: Ability to pass multiple MC files per channel and const correctness#842
KSkwarczynski merged 5 commits intodevelopfrom
kskwarczynski/breaking/multipleFiles

Conversation

@KSkwarczynski
Copy link
Copy Markdown
Member

@KSkwarczynski KSkwarczynski commented Mar 27, 2026

Pull request description

Now code instead of
mtuplefile: "numu_x_numu"
expects
mtuplefile: ["numu_x_numu"]

This allows to pass multiple files per channels, which is getting increasingly needed by DUNE, but I imagine HK will benefit as well.

Need to merge: mach3-software/MaCh3Tutorial#236 first

Changes or fixes

  • Now getters correctly follow const correctness
  • Removed get Xvar/Yvar name now we should use GetKinVarName
  • Target and Mode are not longer part of EventInfo, now they can be acessed via ReturnKinemPar
  • Move some public function to private/protected
  • Removed sanitise input from ProduceToys

@KSkwarczynski KSkwarczynski self-assigned this Mar 27, 2026
@github-actions
Copy link
Copy Markdown

Hi @KSkwarczynski, thank you for contributing to MaCh3! Please wait for MaCh3 developers to review your PR. If no one answers within a week, please message people from this list: https://github.com/orgs/mach3-software/teams/mach3admin . While waiting, please enjoy this

meme

Use this action on your projects. Use jokes on issues instead.

@KSkwarczynski KSkwarczynski merged commit e584915 into develop Mar 30, 2026
27 checks passed
@KSkwarczynski KSkwarczynski deleted the kskwarczynski/breaking/multipleFiles branch March 30, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

MCMC MCMC related Samples

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant