fix(www): prevent build failure when NEXT_PUBLIC_APP_URL is missing#903
Merged
Yeom-JinHo merged 2 commits intomagicuidesign:mainfrom Mar 2, 2026
Merged
fix(www): prevent build failure when NEXT_PUBLIC_APP_URL is missing#903Yeom-JinHo merged 2 commits intomagicuidesign:mainfrom
Yeom-JinHo merged 2 commits intomagicuidesign:mainfrom
Conversation
|
@Yeom-JinHo is attempting to deploy a commit to the product-studio Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR focuses on fixing production build failures when
NEXT_PUBLIC_APP_URLis missing in thewwwapp.Changes
absoluteUrl()to usesiteConfig.urlwhenNEXT_PUBLIC_APP_URLis not set.absoluteUrl("/og")in docs and showcase metadata.new URL()-based composition to ensure valid absolute URLs for metadata and structured data.Metadataimport toimport typeinutils.ts.Motivation
TypeError: Invalid URLwhenNEXT_PUBLIC_APP_URLwas empty or undefined.Breaking Changes
NEXT_PUBLIC_APP_URLis provided.siteConfig.urlinstead of failing the build.