Conversation
zrm22
reviewed
Dec 19, 2025
| val fileName = fastaPath.fileName.toString() | ||
| // Remove extension (including .gz if present) | ||
| val baseName = fileName | ||
| .replace(Regex("\\.(fa|fasta|fna)(\\.gz)?$"), "") |
Contributor
There was a problem hiding this comment.
You might want to move the Regex out of the map{}. The compiler might fix this, but historically declaring a Regex on the fly is a pretty costly operation in Java.
Member
Author
There was a problem hiding this comment.
Interesting. I did not know that! Fixed.
zrm22
approved these changes
Dec 19, 2025
smm477
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves default parameter generation and guardrails during recombination steps
Features
Bug Fixes
Breaking Changes
Checklist
versioninbuild.gradle.kts(REQUIRED - see below)