Open
Conversation
* added react-cdn folder * added docs and styles * added docs and styles * added docs and styles * added docs and styles * fixed mobile view * fixed comments * fixed comments * fixed comments * fixed comments * fixed comments * added csprclick check + new buymecoffe * fixed comments * fixed comments * fixed comments * fixed lint and added new rules * fixed csprclick loading * fixed csprclick loading * removed unnecessary check for csprclick availability * cleaned up codebase --------- Co-authored-by: sasha kushnir <sasha@make.sevices>
* updated csprclick to 1.12 * updated csprclick to 1.12 * updated csprclick to 1.12 * updated csprclick to 1.12 * added cspr.design lib * cleaned up the Welcome screen * removed local colors file * fixed theme issue * fixed theme issue --------- Co-authored-by: sasha kushnir <sasha@make.sevices>
davidatwhiletrue
requested changes
Feb 26, 2026
Member
davidatwhiletrue
left a comment
davidatwhiletrue
left a comment
There was a problem hiding this comment.
@LookerClocker , please check my comments. Also, I couldn't build the app. vite complains about cspr-design types not being avilable?
src/components/container.tsx:2:28 - error TS7016: Could not find a declaration file for module '@make-software/cspr-design'. '/Users/davidhernando/MAKE/TEMP/csprclick-examples/csprclick-react/node_modules/@make-software/cspr-design/dist/cspr-design.es.js' implicitly has an 'any' type.
There are types at '/Users/davidhernando/MAKE/TEMP/csprclick-examples/csprclick-react/node_modules/@make-software/cspr-design/dist/lib/index.d.ts', but this result could not be resolved when respecting package.json "exports". The '@make-software/cspr-design' library may need to update its package.json or typings.
2 import { FlexColumn } from "@make-software/cspr-design";
| window.addEventListener('csprclick:loaded', () => { | ||
| addListeners(); | ||
| }); | ||
| }, []); |
Member
There was a problem hiding this comment.
remove the listener with return.
| import { Section } from './Section'; | ||
| import Prism from 'prismjs'; | ||
|
|
||
| export const UseClickRefHook = () => { |
Member
There was a problem hiding this comment.
This name must come from old content. Please, rename it.
| <pre> | ||
| <code className={'language-javascript'}> | ||
| {` | ||
| <head> |
Member
There was a problem hiding this comment.
This text must be updated and be aligned with how we download the script in App.tsx.
| `; | ||
|
|
||
| // CTA Button | ||
| export const LearnMoreButton = styled.div` |
Member
There was a problem hiding this comment.
Could we use a button from cspr-design library instead?
|
|
||
| declare global { | ||
| interface Window { | ||
| csprclick?: any; |
Member
There was a problem hiding this comment.
Use specific type for csprclick
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist