activator/client/controller: use DzPrefixFirstIP as multicast tunnel endpoint#2884
Closed
martinsander00 wants to merge 1 commit intomainfrom
Closed
activator/client/controller: use DzPrefixFirstIP as multicast tunnel endpoint#2884martinsander00 wants to merge 1 commit intomainfrom
martinsander00 wants to merge 1 commit intomainfrom
Conversation
bead9fd to
a9440b9
Compare
a9440b9 to
41c2fba
Compare
b6a4071 to
2b748b3
Compare
2b748b3 to
8f35acd
Compare
…endpoint Multicast tunnels now use the device's DZ prefix first IP (network address of dz_prefixes[0]) instead of public_ip for both tunnel source (device side) and tunnel destination (client side). This enables simultaneous IBRL and multicast tunnels on the same device with unique GRE (src, dst) pairs, eliminating demux collisions. - Client: multicast tunnel_endpoint set to DzPrefixFirstIP; when IBRL exists, multicast reuses same device instead of excluding it - Activator: validate DzPrefixFirstIP as tunnel endpoint; reserve network address of each dz_prefix so it cannot be allocated as a user dz_ip - Controller: no logic changes needed (already uses user.TunnelEndpoint when set); added test coverage - E2E: DzPrefixFirstIP as secondary IP on Ethernet1; single-client tests now verify same-device IBRL+multicast coexistence
8f35acd to
3a9f247
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: malbeclabs/infra#522
Summary
dz_prefixes[0]) as both tunnel source (device side) and tunnel destination (client side), instead of the device's public IP — enabling simultaneous IBRL and multicast tunnels on the same device with unique GRE (src, dst) pairstunnel_endpointtoDzPrefixFirstIP; when IBRL already exists, multicast reuses the same device instead of excluding itDzPrefixFirstIPas a valid tunnel endpoint and explicitly reserves the network address of eachdz_prefixblock so it cannot be allocated as a userdz_ipDzPrefixFirstIPas a secondary IP on device Ethernet1; single-client tests now verify same-device IBRL+multicast coexistenceBackward Compatibility
DzPrefixFirstIPavailable: usesDzPrefixFirstIPdz_prefixes: falls back toPublicIPuser.TunnelEndpointwhen set, falling back toPublicIPTesting Verification
test_is_valid_tunnel_endpoint_matches_dz_prefix,test_dz_prefix_first_ip_reserved_at_init, updated IP count expectations for reservationDzPrefixFirstIP, IBRL+multicast coexistence on same devicemulticast_uses_dz_prefix_first_ip_as_tunnel_sourceverifyingUnderlaySrcIPmatchesDzPrefixFirstIPTestE2E_Multicast,TestE2E_IBRL_Multicast_Coexistence,TestE2E_MultiTunnel_SameDevice