Merged
Conversation
martinsander00
approved these changes
Feb 10, 2026
Contributor
martinsander00
left a comment
martinsander00
left a comment
There was a problem hiding this comment.
Lint issues but lgtm
fix lint
juan-malbeclabs
force-pushed
the
jo/update_user_delete
branch
from
dd799f4 to
7908ccc
Compare
ben-dz
pushed a commit
that referenced
this pull request
Feb 10, 2026
This pull request improves the user deletion process by ensuring that multicast group subscriptions are only attempted for groups that currently exist. The main change is to check for the existence of each multicast group before attempting to unsubscribe, which prevents errors when a user is associated with groups that may have been deleted. Multicast group handling improvements: * Added a call to `ListMulticastGroupCommand` to fetch the current list of multicast groups before processing user subscriptions. * Updated the deletion logic to only execute `SubscribeMulticastGroupCommand` for groups that exist in the current multicast group list, preventing attempts to unsubscribe from non-existent groups. [[1]](diffhunk://#diff-11779c00a2224ce8e960532a9494334146983fe1f64b619779c6cf1d2c8c2a06R32-R35) [[2]](diffhunk://#diff-11779c00a2224ce8e960532a9494334146983fe1f64b619779c6cf1d2c8c2a06R45)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the user deletion process by ensuring that multicast group subscriptions are only attempted for groups that currently exist. The main change is to check for the existence of each multicast group before attempting to unsubscribe, which prevents errors when a user is associated with groups that may have been deleted.
Multicast group handling improvements:
ListMulticastGroupCommandto fetch the current list of multicast groups before processing user subscriptions.SubscribeMulticastGroupCommandfor groups that exist in the current multicast group list, preventing attempts to unsubscribe from non-existent groups. [1] [2]