controller: implement IS-IS flex-algo config and BGP color stamping (RFC-18, PR 3/4)#3476
Draft
ben-malbeclabs wants to merge 11 commits intobc/rfc18-activatorfrom
Draft
controller: implement IS-IS flex-algo config and BGP color stamping (RFC-18, PR 3/4)#3476ben-malbeclabs wants to merge 11 commits intobc/rfc18-activatorfrom
ben-malbeclabs wants to merge 11 commits intobc/rfc18-activatorfrom
Conversation
ben-malbeclabs
force-pushed
the
bc/rfc18-controller
branch
from
9f578e3 to
04b42de
Compare
ben-malbeclabs
changed the base branch from
bc/rfc18-smartcontract
to
bc/rfc18-activator
…ShouldStamp helper
…BGP color stamping
set extcommunity color {{ .TenantTopologyColors }} produced
"set extcommunity color color 1" because TenantTopologyColors already
includes the "color N" prefix. Removed the redundant "color" keyword
from the template.
Converted flex-algo render tests from substring assertions to golden
fixtures with -update flag regeneration. Added four scenarios: single
topology, multi-topology (unicast-default + high-bandwidth + CYOA),
unicast-drained, and link-excluded.
…ace V3, and startup check
- Emit no router traffic-engineering / no traffic-engineering / no next-hop
resolution ribs when flex_algo.enabled is false (RFC-18 revert requirement)
- Render flex-algo definition block for Exclude-constraint topologies
- Fix internal Go SDK to correctly deserialize InterfaceV3
- Block flex-algo config push when any VPNv4 loopback is missing node-segment
data instead of just logging
flex-algo string-check tests with golden fixtures
ben-malbeclabs
force-pushed
the
bc/rfc18-controller
branch
from
04b42de to
25fe2c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
features.yamlconfig file support (--features-configflag on the controller). Aflex_algo.enabledflag gates all flex-algo config generation; when disabled, the controller produces identical output to today.system-colored-tunnel-ribas the BGP next-hop resolution source.include_topologiesset, subject to per-tenant and per-device allow/exclude lists infeatures.yaml.node-segment ipv4 indexlines for each flex-algo, sourced from segment routing IDs backfilled by the activator.base.config.flex-algo.txt,base.config.flex-algo-disabled.txt) replacing string-based assertions in render tests.Diff Breakdown
Fixture-heavy: golden config files for flex-algo enabled/disabled cases replace ~200 lines of string assertions.
Key files (click to expand)
controlplane/controller/internal/controller/server.go— core config generation: admin-group tagging, flex-algo topology blocks, color community stamping, node-segment linescontrolplane/controller/internal/controller/templates/tunnel.tmpl— IS-IS admin-group, flex-algo, colored-tunnel-rib, and BGP color extcommunity route-mapscontrolplane/controller/internal/controller/features_config.go—FeaturesConfigstruct withflex_algo.enabled, per-tenant/device stamping allowlists, link exclude listscontrolplane/controller/internal/controller/models.go— new fields surfacing topology and node-segment data for template renderingcontrolplane/controller/cmd/controller/main.go—--features-configflag wiring and startup loggingcontrolplane/controller/fixtures/base.config.flex-algo.txt— golden fixture: full flex-algo config outputcontrolplane/controller/fixtures/base.config.flex-algo-disabled.txt— golden fixture: config with flex-algo disabled (identical to today)Testing Verification
go test ./controlplane/controller/...passesfeatures_config_test.gocovers YAML parsing including empty/partial configs and defaults