smartcontract: rename subscribe processor for clarity#3499
Open
martinsander00 wants to merge 2 commits intomainfrom
Open
smartcontract: rename subscribe processor for clarity#3499martinsander00 wants to merge 2 commits intomainfrom
martinsander00 wants to merge 2 commits intomainfrom
Conversation
Rename subscribe_user_to_multicastgroup → update_user_multicastgroup_subscription and process_subscribe_multicastgroup → process_update_multicastgroup_subscription to reflect that these functions handle both subscribe and unsubscribe. Simplify the status guard to use a positive is_subscribe check instead of double-negated !is_unsubscribe_only. Resolves #3498
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #3498
Summary
process_subscribe_multicastgroup→process_update_multicastgroup_subscriptionandsubscribe_user_to_multicastgroup→update_user_multicastgroup_subscriptionto reflect that these functions handle both subscribe and unsubscribeis_subscribecheck instead of double-negated!is_unsubscribe_only, making the unsubscribe bypass for pending users easier to reason aboutLines of Code
Testing Verification
multicastgroup_subscribe_test,create_subscribe_user_test, anduser_onchain_allocation_testsuites cover all subscribe/unsubscribe paths including the pending user regression added in feat(serviceability): allow pending users with subs to be deleted #3494