Fix pg db name argument#131
Closed
NathanaelRea wants to merge 2 commits intomalloydata:mainfrom
Closed
Conversation
commander saves the long arg in camelCase. It was using databaseName, which was not captured when saving the connection
-d is used in root args as --debug
Author
|
I believe this was fixed in the recent args refactor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes:
--database-name, the variable was passed asdatabaseName, but the connection was looking fordatabase, and not saving the name in the config.-das--debug, which will eat any-dused for database connections. Therefore I moved both postgres and snowflake-dto-nfor "database name"edit: accidentally closed