Skip to content

Fixes for post_ack_mechanism #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avdgrinten merged 2 commits into from
Mar 20, 2026
Merged

Fixes for post_ack_mechanism #42

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02f1224
post-ack: Fix completion handling in detach()
avdgrinten Mar 20, 2026
36124e3
post-ack: Increment poll sequence on completion
avdgrinten Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 17 additions & 8 deletions include/async/post-ack.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,12 +275,15 @@ struct post_ack_agent {

auto n = nd->acks_left.fetch_sub(1, std::memory_order_acq_rel);
assert(n >= 1);
if(n == 1)
if(n == 1) {
mech_->queue_.erase(mech_->queue_.iterator_to(nd));

// Run the completion handler without locks.
lock.unlock();
nd->complete();
// Run the completion handler without locks.
lock.unlock();
nd->complete();
}else{
lock.unlock();
}

++poll_seq_;
if(retire_seq == poll_seq_) // Avoid re-locking.
Expand All @@ -305,7 +308,7 @@ struct post_ack_agent {
void start() {
assert(agnt_->mech_);

auto seq = agnt_->poll_seq_++;
auto seq = agnt_->poll_seq_;

{
frg::unique_lock lock(agnt_->mech_->mutex_);
Expand All @@ -330,13 +333,17 @@ struct post_ack_agent {
}
}

if(nd)
++agnt_->poll_seq_;
execution::set_value(receiver_, post_ack_handle<T>{agnt_->mech_, nd});
}

private:
void complete() override {
if(cobs_.try_reset())
if(cobs_.try_reset()) {
++agnt_->poll_seq_;
execution::set_value(receiver_, post_ack_handle<T>{agnt_->mech_, nd});
}
}

void complete_cancel() {
Expand All @@ -350,10 +357,12 @@ struct post_ack_agent {
}
}

if(nd)
if(nd) {
++agnt_->poll_seq_;
execution::set_value(receiver_, post_ack_handle<T>{agnt_->mech_, nd});
else
}else{
execution::set_value(receiver_, post_ack_handle<T>{});
}
}

post_ack_agent *agnt_;
Expand Down
Loading