Skip to content

Console use guid lookup when player offline #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
billy1arm merged 1 commit into from
Mar 9, 2026
Merged

Console use guid lookup when player offline #266

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 29 additions & 2 deletions src/game/WorldHandlers/Chat.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3526,15 +3526,42 @@ bool ChatHandler::ExtractPlayerTarget(char** args, Player** player /*= NULL*/, O
{
*player = pl;
}

ObjectGuid guid = pl ? pl->GetObjectGuid() : ObjectGuid();

// Console with a selected player that is now offline: fall back to stored GUID
if (!pl && !m_session)
{
uint32 accountId = GetAccountId();
auto itr = m_consoleSelectedPlayers.find(accountId);
if (itr != m_consoleSelectedPlayers.end())
guid = itr->second;
}

// if allowed player guid (if no then only online players allowed)
if (player_guid)
{
*player_guid = pl ? pl->GetObjectGuid() : ObjectGuid();
*player_guid = guid;
}

if (player_name)
{
*player_name = pl ? pl->GetName() : "";
if (pl)
*player_name = pl->GetName();
else if (guid)
{
std::string name;
if (!sObjectMgr.GetPlayerNameByGUID(guid, name) || name.empty())
{
if (player_guid)
*player_guid = ObjectGuid();
*player_name = "";
}
else
*player_name = name;
}
else
*player_name = "";
}
}

Expand Down