Creature position update fix#274
Merged
billy1arm merged 1 commit intomangoszero:masterfrom Mar 16, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts Unit::InterruptMoving to update server-side position correctly when interrupting spline movement, aligning non-player behavior with other movement update paths and reducing relocation mismatch log noise.
Changes:
- Updates
InterruptMovingto callMap::CreatureRelocationfor non-player units instead ofRelocate. - Keeps
Relocatefor players (unchanged from before), while splitting behavior byTypeId.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
bozimmerman
force-pushed
the
creature_pos_fix
branch
from
bb51199 to
3c3efd3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes InterruptMoving method to update the position correctly for non-players, just like it's done in all of the rest of the code. Honestly, this was not fixing anything important: the mistake would be noticed and corrected later anyway, but when this correction occurred, it logged it, and I just got curious about all those errors in my log and figured out what was going on.
This change is