added support for cross-assembly discriminator properties #124
Open
markusbuschhoff wants to merge 1 commit intomanuc66:masterfrom
Open
added support for cross-assembly discriminator properties #124markusbuschhoff wants to merge 1 commit intomanuc66:masterfrom
markusbuschhoff wants to merge 1 commit intomanuc66:masterfrom
Conversation
…lly qualified names
Owner
|
Could you add another assembly to the solution and a new test case ? Thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... that use fully qualified names
This simple patch allows for using JsonSubTypes with fully qualified or assembly qualified names to access cross-assembly subtypes via discriminator properties.
This also allows to use fully qualified names at all - beforhand they could not be found even if in same assembly.
Example baseclass usage that now can be derived in another assembly: