Update project to Swift 5#186
Closed
s-faychatelard wants to merge 4 commits intomapbox:masterfrom
s-faychatelard:master
Closed
Update project to Swift 5#186s-faychatelard wants to merge 4 commits intomapbox:masterfrom s-faychatelard:master
s-faychatelard wants to merge 4 commits intomapbox:masterfrom
s-faychatelard:master
Conversation
Contributor
|
These changes required a few changes to our CI environment so I've cherry-picked your changes and brought them into #187 with one modification. I downgraded to Swift 4.2 for compatibility with Xcode < 10.2. We will upgrade to Swift 5 soon enough, in the meantime, it's pretty convenient to override the Swift version with both Carthage and CocoaPods. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ennow instead ofEnglish