Handle geojson layers like other layers by digitaltom · Pull Request #605 · mapforge-org/mapforge

digitaltom · 2026-02-02T23:34:37Z

No description provided.

Copilot

Pull request overview

Refactors MapLibre layer handling so GeoJSON layers are treated similarly to other layer types (separate sources/styles per layer) and introduces layer-level flags intended to control clustering/heatmap behavior.

Changes:

Introduces per-layer GeoJSON sources (<type>-source-<layerId>) and new feature lookup helpers in maplibre/layers/layers.js.
Updates various MapLibre modules/controllers to use the new feature lookup approach instead of geojsonData.
Adds a Wikipedia marker icon and extends Layer summaries with heatmap/cluster flags.

Reviewed changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 14 comments.

Show a summary per file

File	Description
public/icons/wikipedia.png	Adds an icon used by the Wikipedia layer features.
app/models/layer.rb	Adds `heatmap`/`cluster` fields and includes them in serialized layer summaries.
app/javascript/maplibre/undo.js	Starts migration away from `geojsonData` imports (but still needs further refactor).
app/javascript/maplibre/styles.js	Updates style initialization and heatmap layer handling; switches feature lookup to `getFeature`.
app/javascript/maplibre/routing/osrm.js	Switches route feature lookup to `getFeature`.
app/javascript/maplibre/map.js	Removes global `geojsonData` usage patterns and shifts rendering toward per-layer sources.
app/javascript/maplibre/layers/layers.js	Initializes per-layer GeoJSON sources/styles and adds `getFeature/getFeatures/hasFeatures`.
app/javascript/maplibre/feature.js	Uses new feature access helpers for edit gating and derived-feature generation inputs.
app/javascript/maplibre/edit.js	Uses new helpers for “untouched map” logic and URL-based selection.
app/javascript/maplibre/controls/shared.js	Updates feature list items to reference the new per-layer source names.
app/javascript/controllers/feature/modal_controller.js	Refactors selected-feature access (now needs `getFeature` import).
app/javascript/controllers/feature/edit_controller.js	Refactors edit-feature access (now needs `getFeature` import).

Comments suppressed due to low confidence (1)

app/javascript/maplibre/map.js:123

initializeMap highlights a URL-selected feature via highlightFeature(feature, true) without passing the feature’s source. Since the default source in highlightFeature is geojson-source (which is no longer created), setFeatureState will fail or highlight the wrong source. Determine the correct source for the feature (e.g., from the owning layer) and pass it explicitly.

    const urlFeatureId = new URLSearchParams(window.location.search).get('f')
    let feature = getFeature(urlFeatureId)
    if (feature) {
      resetControls()
      highlightFeature(feature, true)
      const center = centroid(feature)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

app/models/layer.rb

Copilot · 2026-02-02T23:48:18Z

app/javascript/maplibre/map.js

  // updateData requires a 'GeoJSONSourceDiff', with add/update/remove lists
-  map.getSource('geojson-source').setData(renderedGeojsonData())
+  //map.getSource('geojson-source').setData(renderedGeojsonData())
  console.log('layers:', layers)
-  layers.filter(f => f.type !== 'geojson').forEach((layer) => {
+  layers.forEach((layer) => {
    if (layer.geojson) {
      console.log("Setting layer data", layer.type, layer.id, layer.geojson)
      map.getSource(layer.type + '-source-' + layer.id).setData(layer.geojson, false)


redrawGeojson() no longer calls renderedGeojsonData() and instead pushes layer.geojson directly into each source. This drops the side effects of renderedGeojsonData() (km-marker source updates via renderKmMarkers() and extrusion polygons via renderExtrusionLines()), so km markers / extrusions will stop rendering/updating. Re-introduce those steps in the new per-layer rendering flow (and ensure derived features are included in the appropriate source data).

Copilot · 2026-02-02T23:48:18Z

app/javascript/maplibre/styles.js

-        const feature = geojsonData.features.find(f => f.id === targetId)
+        const feature = getFeature(targetId)
        if (feature) {
          flyToFeature(feature)


When handling onclick-target navigation, flyToFeature(feature) is called without a source. flyToFeature defaults to geojson-source, which no longer exists for per-layer sources, so the follow-up highlight will fail. Pass sourceName (or otherwise resolve the owning source) into flyToFeature.

Suggested change

flyToFeature(feature)

flyToFeature(feature, sourceName)

Copilot · 2026-02-02T23:48:19Z

app/javascript/maplibre/styles.js

    map.addLayer(setSource(styles()[styleName], sourceName))
  })
+  if (heatmap) { map.addLayer(setSource(styles()['heatmap-layer'], sourceName)) }


initializeViewStyles now only adds the heatmap layer when heatmap=true, but existing callers (e.g. overpass layer initialization) invoke it with a single argument. This change will disable rendering for existing heatmap=true overpass queries unless those call sites are updated to pass the flag.

app/javascript/maplibre/feature.js

app/javascript/maplibre/layers/layers.js

app/javascript/maplibre/edit.js

Copilot · 2026-02-02T23:48:20Z

app/javascript/maplibre/layers/layers.js

+    addGeoJSONSource('geojson-source-' + layer.id, false)
+    initializeViewStyles('geojson-source-' + layer.id)


GeoJSON layers are always initialized with cluster=false and without passing the new heatmap flag into initializeViewStyles. Since layer summaries now include cluster/heatmap, these settings appear intended to be configurable but are currently ignored. Consider wiring layer.cluster into addGeoJSONSource(...) and layer.heatmap into initializeViewStyles(..., layer.heatmap).

Suggested change

addGeoJSONSource('geojson-source-' + layer.id, false)

initializeViewStyles('geojson-source-' + layer.id)

addGeoJSONSource('geojson-source-' + layer.id, Boolean(layer.cluster))

initializeViewStyles('geojson-source-' + layer.id, Boolean(layer.heatmap))

app/javascript/maplibre/layers/layers.js

app/javascript/maplibre/map.js

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

app/javascript/maplibre/undo.js

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

app/javascript/maplibre/layers/layers.js

coveralls · 2026-02-06T17:04:17Z

Pull Request Test Coverage Report for Build 21778988546

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

5 of 5 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.001%) to 99.362%

Totals
Change from base Build 21714622559:	0.001%
Covered Lines:	779
Relevant Lines:	784

💛 - Coveralls

app/javascript/maplibre/undo.js

+  let feature = getFeature(prevState.state.id, 'geojson')
+  if (feature) {
+    addRedoState(prevState.type, feature)
+    feature = prevState.state


app/javascript/maplibre/undo.js

+  let feature = getFeature(nextState.state.id, 'geojson')
+  if (feature) {
+    addUndoState(nextState.type, feature, false)
+    feature = nextState.state


app/javascript/maplibre/undo.js

-    addRedoState(prevState.type, geojsonData.features[idx], false)
+  let feature = getFeature(prevState.state.id, 'geojson')
+  if (feature) {
+    addRedoState(prevState.type, feature, false)


app/javascript/maplibre/undo.js

-    addRedoState(prevState.type, geojsonData.features[idx], false)
+  let feature = getFeature(prevState.state.id, 'geojson')
+  if (feature) {
+    addRedoState(prevState.type, feature, false)


Handle geojson layers like other layers

c336539

Copilot AI review requested due to automatic review settings February 2, 2026 23:34

Copilot started reviewing on behalf of digitaltom February 2, 2026 23:34 View session

Copilot AI reviewed Feb 2, 2026

View reviewed changes

depfu bot and others added 11 commits February 3, 2026 23:59

Update @turf/bbox to version 7.3.3

e30eb46

Update @turf/boolean-point-on-line to version 7.3.3

0fe1003

Update rubycritic to version 4.12.0

65b7335

Update globals to version 17.3.0

ece1224

generalize layer - source naming

a28ebd3

Apply suggestion from @Copilot

e78f365

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

only select geojson features for edit

875194f

update brakeman

7b43bd1

fix import

d50c5ac

load layers directly into layers var

e5990ec

move geojson layer methods

c406f0a

github-code-quality bot found potential problems Feb 5, 2026

View reviewed changes

app/javascript/maplibre/undo.js Fixed Show fixed Hide fixed

start to move render methods into specific layers

2ace993

digitaltom marked this pull request as draft February 5, 2026 23:40

digitaltom and others added 5 commits February 6, 2026 00:42

Update app/javascript/maplibre/feature.js

bfd3198

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Merge branch 'main' into unify_layer_handling

b759397

autodetect flyto source

e7600a8

wait for geojson load before styling

fc574be

use layer specific redraw

d26418e

github-code-quality bot found potential problems Feb 6, 2026

View reviewed changes

app/javascript/maplibre/layers/layers.js Fixed Show fixed Hide fixed

move km markers to layers

1ae8389

digitaltom added 3 commits February 6, 2026 23:11

mock more overpass calls

8deee4a

migrate redrawGeojson calls

dd81d6a

migrate undo

1a86f16

github-code-quality bot found potential problems Feb 7, 2026

View reviewed changes

digitaltom added 6 commits February 7, 2026 01:58

migrate off from redrawGeojson

0ef4355

avoid recursion

0bef4f9

fix line symbols

b3f7b57

fix km markers

0717112

improved layer loading promises

f65d36e

support heatmap + cluster again in overpass

bf4b86d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handle geojson layers like other layers#605

Handle geojson layers like other layers#605
digitaltom wants to merge 28 commits intomainfrom
unify_layer_handling

digitaltom commented Feb 2, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI Feb 2, 2026

Uh oh!

Copilot AI Feb 2, 2026

Uh oh!

Copilot AI Feb 2, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Feb 2, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coveralls commented Feb 6, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		addGeoJSONSource('geojson-source-' + layer.id, false)
		initializeViewStyles('geojson-source-' + layer.id)

Conversation

digitaltom commented Feb 2, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coveralls commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 21778988546

Warning: This coverage report may be inaccurate.

Details

💛 - Coveralls

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coveralls commented Feb 6, 2026 •

edited

Loading