Conversation
Modified the image_check function to add the "zoom" to the options argument of kwarg_check. This is because in mapillary.interface, the following functions allow for zoom as a keyword argument: 1. get_image_looking_at_controller 2. get_image_close_to_controller The first line of these functions use image_check to filter through only the correct keys. Before the change, if zoom was supplied, image_check would throw an InvalidKwargError exception in both these functions.
facebook-github-bot
added
the
CLA Signed
Contributor
|
Looks good, merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified the image_check function to add the "zoom" to the options argument of kwarg_check. This is because in mapillary.interface, the following functions allow for zoom as a keyword argument:
The first line of these functions use image_check to filter through only the correct keys. Before the change, if zoom was supplied, image_check would throw an InvalidKwargError exception in both these functions.