chore(deps): general dependency upgrade and renovation#25
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request upgrades the project's dependencies and migrates from the deprecated request library to axios. The migration involves updating the HTTP request handling to use axios's Promise-based API and updating the test infrastructure to modern Node.js versions.
Key changes:
- Migration from
requesttoaxiosfor HTTP requests, converting callback-based patterns to Promise-based patterns - Upgrade of Node.js version from 8.x to 20.x and upgrade of all development dependencies (ESLint 9.x, Mocha 11.x)
- Fixed a critical bug in the method check logic (parenthesis placement in indexOf check)
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updated dependencies: replaced request with axios, upgraded ESLint, Mocha, and conventional-changelog tooling to latest versions |
| lib/mite-api.js | Migrated from request callback API to axios Promise API, changed body to data parameter, fixed indexOf parenthesis bug |
| test/mock/axios.js | Converted mock from callback-based to Promise-based, updated response structure from request format to axios format |
| test/test.js | Updated mock import and usage from requestMock to axiosMock, fixed typo in comment |
| eslint.config.js | Added new flat config format for ESLint 9.x |
| .eslintrc | Removed legacy ESLint configuration file |
| .nvmrc | Updated Node.js version from 8.17.0 to 20 |
| .npmrc | Added configuration for exact dependency versions and security settings |
| .github/workflows/test.yml | Updated Node versions and GitHub Actions versions, but contains a typo in matrix key |
| .github/workflows/lint.yml | Updated Node versions and GitHub Actions versions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
|
@Ephigenia I've opened a new pull request, #26, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: Ephigenia <73654+Ephigenia@users.noreply.github.com>
Co-authored-by: Ephigenia <73654+Ephigenia@users.noreply.github.com>
Fix makeRequest to return Promise for proper async chaining
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
upgrades the project's dependencies and migrates from the deprecated
requestlibrary toaxios. The migration involves updating the HTTP request handling to use axios's Promise-based API and updating the test infrastructure to modern Node.js versions.