Make input method for MMCIFParser and MMCIFReader more flexible#4
Merged
marinegor merged 4 commits intomarinegor:feature/mmciffrom Nov 17, 2025
Merged
Make input method for MMCIFParser and MMCIFReader more flexible#4marinegor merged 4 commits intomarinegor:feature/mmciffrom
marinegor merged 4 commits intomarinegor:feature/mmciffrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@marinegor This will allow the MMCIFParser and MMCIFReader to accept any valid mda topology/trajectory input instead of just a filepath string- so pathlib.Path, StringIO, mda.lib.util.NamedStream, for example
I added a test for legacy PDB parsing for these same input methods, but feel free to remove since it sounds like that might be out of scope
MDAnalysis#4712