Open
Conversation
|
|
mfix-stripe
reviewed
Jul 7, 2025
Collaborator
There was a problem hiding this comment.
We might want to use the square version (seen in the favicon on our website) instead of the rectangle one, for file icons.
Author
There was a problem hiding this comment.
Ya that would probably look better. Do you have an SVG version of that icon? I can update the PR.
Author
There was a problem hiding this comment.
@mfix-stripe following up, do you have an SVG link I can use?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add file icons for Markdoc files
Closes markdoc/markdoc#558
This PR adds visual file icons for Markdoc files in VSCode's file explorer to improve developer experience and file identification.
Changes
.mdoc,.markdoc, and.markdoc.mdextensions.vscodeignoreto include icons in extension packageImplementation
Testing